Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm install/build issue with latest vsce #8

Merged
merged 1 commit into from Nov 4, 2021

Conversation

sourishkrout
Copy link
Contributor

Upgrade base image to latest LTS node:16-slim.

@sourishkrout
Copy link
Contributor Author

Pending: microsoft/vscode-vsce#645

@sourishkrout sourishkrout marked this pull request as ready for review November 4, 2021 17:45
@sourishkrout
Copy link
Contributor Author

sourishkrout commented Nov 4, 2021

Based on the fix of microsoft/vscode-vsce#645 and the subsequent release https://github.com/microsoft/vscode-vsce/releases/tag/v2.0.0 this will work now.

Please let me know if there's anything else you need @lannonbr. Thanks!

@lannonbr
Copy link
Owner

lannonbr commented Nov 4, 2021

Nope, this is good to go. Let me merge it and cut a release

@lannonbr lannonbr merged commit 0f3391e into lannonbr:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants