Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint rule to detect side effects (which prevent tree shaking), Add script that checks presence of side effects with rollup #323

Merged
merged 8 commits into from Mar 16, 2023
Merged

Add eslint rule to detect side effects (which prevent tree shaking), Add script that checks presence of side effects with rollup #323

merged 8 commits into from Mar 16, 2023
+255 −115

Conversation

nfcampos
Copy link
Collaborator

No description provided.

@nfcampos
Copy link
Collaborator Author

mrdoob/three.js#24199
evanw/esbuild#1420
mapbox/node-pre-gyp#661
https://esbuild.github.io/api/

nfcampos
nfcampos commented Mar 16, 2023
View reviewed changes
langchain/src/cache.ts Outdated Show resolved Hide resolved
@nfcampos nfcampos self-assigned this Mar 16, 2023
@nfcampos nfcampos changed the title Add eslint rule to detect (some) side effects (that prevent tree shaking) Add eslint rule to detect (some) side effects (that prevent tree shaking), Add script that checks with presence of side effects with rollup Mar 16, 2023
@nfcampos nfcampos changed the title Add eslint rule to detect (some) side effects (that prevent tree shaking), Add script that checks with presence of side effects with rollup Add eslint rule to detect side effects (that prevent tree shaking), Add script that checks with presence of side effects with rollup Mar 16, 2023
@nfcampos nfcampos marked this pull request as ready for review March 16, 2023 14:10
@nfcampos nfcampos changed the title Add eslint rule to detect side effects (that prevent tree shaking), Add script that checks with presence of side effects with rollup Add eslint rule to detect side effects (that prevent tree shaking), Add script that checks presence of side effects with rollup Mar 16, 2023
@nfcampos nfcampos changed the title Add eslint rule to detect side effects (that prevent tree shaking), Add script that checks presence of side effects with rollup Add eslint rule to detect side effects (which prevent tree shaking), Add script that checks presence of side effects with rollup Mar 16, 2023
@nfcampos nfcampos requested a review from agola11 March 16, 2023 15:47
agola11
agola11 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@agola11 agola11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfcampos nfcampos merged commit 13188db into main Mar 16, 2023
12 checks passed
@nfcampos nfcampos deleted the nc/side-effects-tree-shake branch March 16, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agola11 agola11 agola11 approved these changes

Assignees

@nfcampos nfcampos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nfcampos @agola11