Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type inference for Plugin Managers #165

Merged
merged 14 commits into from
Jul 10, 2022
Merged

Improve type inference for Plugin Managers #165

merged 14 commits into from
Jul 10, 2022

Commits on Jun 13, 2022

  1. Adds a stub for psr container 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2211cc3 View commit details
    Browse the repository at this point in the history

  2. Improve type inference for plugin manager 

    Link: laminas/laminas-servicemanager#137
Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    0620925 View commit details
    Browse the repository at this point in the history

  3. Updates Service Manager and stdLib to versions with type improvements 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    6cc94b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Updates locked dependencies and bumps laminas-servicemanager to 3.14.0 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    a4aebf4 View commit details
    Browse the repository at this point in the history

  2. Remove tests relevant to service manager v2 as it is no longer instal… 

    …lable

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    1125985 View commit details
    Browse the repository at this point in the history

  3. Relax constraint on template parameter got get() so that non-object… 

    … types can be returned by implemetors

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    62899d9 View commit details
    Browse the repository at this point in the history

  4. extract templated instance type to a psalm-type so it can be imported… 

    … elsewhere

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    1856d16 View commit details
    Browse the repository at this point in the history

  5. Improve type inference for other plugin managers and the plugin metho… 

    …d of the renderer

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    9d4fc2c View commit details
    Browse the repository at this point in the history

  6. Update tests to refer to helpers by FQCN where appropriate 

    Enables the removal of a number of assertions and var annotations

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    7a2fadc View commit details
    Browse the repository at this point in the history

  7. Update psalm baseline with fixed errors 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    2b6b4c8 View commit details
    Browse the repository at this point in the history

  8. Ignore false-negative phpcs violations 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    22850b2 View commit details
    Browse the repository at this point in the history

  9. Ignore platform requirements on 8.0 because we are stuck with laminas… 

    …/console until 3.0

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    7028b2a View commit details
    Browse the repository at this point in the history

  10. Remove return types from the stub, favouring annotations which fits e… 

    …xisting implementors such as those found in service manager - this silences unusual errors from psalm.

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    0133bae View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. Lock phpdoc-parser to 1.5.1 due to an incompatibility with slevomat c… 

    …oding standard 7.2 and phpdoc-parser 1.6.x

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    fc209b8 View commit details
    Browse the repository at this point in the history