Fix some 8.2 compatibility issues in Date validator

[gsteel]

Q	A
Bugfix	yes
QA	yes

Description

Testing a local project under 8.2-RC reveals a problem specific to the Date validator, where DateTime::getLastErrors() is potentially false. Even given https://3v4l.org/HBq0q - I can't get a test to actually return false from this method because it's 8.2 specific, so verifying the fix is a tough one.

Looking at https://3v4l.org/3QsKY - Only 8.2 returns false after a date operation that causes no errors.

A couple of other tests had complaints about dynamic properties and I've silenced a number of tests that don't perform any assertions depending on the data providers.

[boesing]

Does psalm already support that false return value of DateTime#getLastErrors?

If so, its absolutely okay to early return without actually having a test which verifies if the methods return value is false is due to the fact that DateTime::getLastErrors returns an array with warning_count/error_count being positive-int or due to the return value false.

Overall, LGTM.

[gsteel]

Related: vimeo/psalm#8478

[boesing]

@gsteel you actually have to disable ignoreInternalFunctionFalseReturn in psalm config.

Sadly, thats enabled by default.

Ref: vimeo/psalm#7758 (comment)

[gsteel]

@boesing - this should be good to go. The conditional in Date validator is required for PHP 8.2 though due to real errors such as array offset on bool… so I guess we'll just leave it in the baseline.

I did take a quick look at disabling ignoreInternalFunctionFalseReturn in psalm.xml but that yielded another 200 errors. Happy to disable it and expand the baseline if you'd like to see that here?

Is it worth trawling through the options and coming up with a standard config for all of the components do you think?

[Ocramius]

Is it worth trawling through the options and coming up with a standard config for all of the components do you think?

Yes, but not here :D

[Ocramius]

LGTM, thanks @gsteel!