Fixes Test Failures relating to InputFilter Regression and Doctrine Annotations Changes #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st failures Doctrine Annotations now converts deprecations to exceptions ref: doctrine/annotations#438 Signed-off-by: George Steel <george@net-glue.co.uk>
|
Probably going to need laminas/laminas-inputfilter#60 before this will go green. Note: relevant tests were passing in |
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
…s up with the service names used in input filter and improves type inference Signed-off-by: George Steel <george@net-glue.co.uk>
…Specification` - a psalm type will need to be imported here from `inputfilter` Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
doctrine-annotation-deprecations
branch
from
b6b10c1
to
033599f
Compare
gsteel
changed the title
1.13.3 to solve test failures
gsteel
force-pushed
the
doctrine-annotation-deprecations
branch
from
033599f
to
e5e87e6
Compare
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
doctrine-annotation-deprecations
branch
from
e5e87e6
to
6766141
Compare
|
🚢 Thanks @gsteel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doctrine Annotations now converts deprecations to exceptions (ref: doctrine/annotations#438) but it's difficult to tell when the internal call to
trigger_errorfor the deprecation fires vs the exception thrown from annotations, event thoughconvertDeprecationsToExceptionsis active here.This pull also updates
inputfilterto the latest release WRT laminas/laminas-inputfilter#60A failing test was occurring, due to other changes in InputFilter where factories are now fetching the
InputFilterManageret al by FQCN rather than alias. This broke theFormAbstractServiceFactoryTestbecause of the contrived ServiceManager config. This shouldn't be an issue for consumers because they would be pulling services from a fully configured ServiceManger (The aliases and services haven't changed)This should help other pulls to go green on latest deps