Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify redirects of legacy docs #76

Merged
merged 1 commit into from Oct 13, 2021
Merged

Simplify redirects of legacy docs #76

merged 1 commit into from Oct 13, 2021

Conversation

driehle
Copy link
Contributor

@driehle driehle commented Oct 12, 2021

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

The docs folder contains several manual redirects, i.d. HTML documents with a hard-coded redirect for legacy URLs. With the adoption of the MkDocs redirect plugin there is a simpler solution available.

This PR moves the redirects for legacy URLs in mkdocs.yml and removes the manually created HTML documents from Git.

Signed-off-by: Dennis Riehle <webmaster@riehle-web.com>
@froschdesign froschdesign added Documentation Enhancement hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 13, 2021
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration and file paths are correct. 👍
Great contribution, as always!

@froschdesign
Copy link
Member

This pull request should be added to one of the next releases because the changes do not bring any real improvements for the end user.

@Ocramius Ocramius changed the base branch from 2.8.x to 2.9.x October 13, 2021 08:28
@Ocramius Ocramius added this to the 2.9.0 milestone Oct 13, 2021
@Ocramius Ocramius self-assigned this Oct 13, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius merged commit ebfa4fa into laminas:2.9.x Oct 13, 2021
@Ocramius
Copy link
Member

Thanks @driehle!

@driehle driehle deleted the update/simplify-doc-redirects branch October 22, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Enhancement hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants