Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Using php >= 7.3 syntax, where possible #75

Merged
merged 1 commit into from Sep 26, 2021
Merged

[QA] Using php >= 7.3 syntax, where possible #75

merged 1 commit into from Sep 26, 2021

Conversation

samsonasik
Copy link
Member

Q A
QA yes

Description

Update to use php <= 7.3 syntaxes:

  • ternary to null coalesce since php 7.0
  • constant visibility since php 7.1

@samsonasik
[Syntax] Using php <= 7.3 syntaxes
aec7afb 
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik
Copy link
Member Author

All green 🎉

@Ocramius Ocramius changed the title [QA] Using php <= 7.3 syntaxes [QA] Using php >= 7.3 syntaxes Sep 26, 2021
@Ocramius Ocramius self-assigned this Sep 26, 2021
@Ocramius Ocramius added this to the 2.9.0 milestone Sep 26, 2021
@Ocramius Ocramius merged commit 8b3a954 into laminas:2.9.x Sep 26, 2021
@Ocramius Ocramius changed the title [QA] Using php >= 7.3 syntaxes [QA] Using php >= 7.3 syntax, where possible Sep 26, 2021
@samsonasik samsonasik deleted the using-php-73-or-less-syntax branch September 26, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samsonasik @Ocramius