Refined types as per laminas/laminas-coding-standard:2.3.x upgrades
#106
+335
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
force-pushed
the
feature/laminas-coding-standard-2.3.x-type-refinements
branch
from
6b8f703 to
126124b
Compare
In laminas#104 (duplicate), we improved the types of internal and public API. These were mixed with coding style improvements. The coding style improvements have been merged separately via laminas#103, so this patch only includes the type/docblock improvements, which should ease the potential evolution of the API of this package.
Ocramius
force-pushed
the
feature/laminas-coding-standard-2.3.x-type-refinements
branch
from
126124b to
2539f32
Compare
Ocramius
commented
Jul 7, 2022
Ocramius
commented
Jul 7, 2022
boesing
requested changes
Jul 7, 2022
| @@ -8,9 +8,10 @@ | |||
| use function Laminas\Diactoros\parseCookieHeader as laminas_parseCookieHeader; | |||
There was a problem hiding this comment.
Maybe we just drop this as we already removed support for the old zendframework implementation by adding conflict to composer.json?
There was a problem hiding this comment.
We do declare these symbols: we can drop them, but not in this patch 🤔
Ocramius
added a commit
that referenced
this pull request
Jul 7, 2022
Ocramius
force-pushed
the
feature/laminas-coding-standard-2.3.x-type-refinements
branch
from
dfa990d to
7880719
Compare
gsteel
approved these changes
Jul 7, 2022
|
🚢 then - will cut a release, hoping for quick feedback in case of breakages |
Ocramius
deleted the
feature/laminas-coding-standard-2.3.x-type-refinements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #104 (duplicate), we improved the types of internal and
public API. These were mixed with coding style improvements.
The coding style improvements have been merged separately via #103,
so this patch only includes the type/docblock improvements, which should ease the potential evolution of the
API of this package.