Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation of MSSQL extension #235

Open
wants to merge 3 commits into
base: 1.40.x
Choose a base branch
from

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented May 8, 2024

Q A
Bugfix yes

Description

CI is currently failing - looks like the asset locations are incorrect for https://github.com/microsoft/msphpsql/releases/tag/v5.12.0

@gsteel gsteel requested a review from Xerkus May 8, 2024 09:13
@gsteel gsteel force-pushed the fix-ms-sql-install branch 2 times, most recently from 7dc4aa8 to ff46fa3 Compare May 8, 2024 09:29
Copy link
Member

@Xerkus Xerkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did they change artifacts?

mods-install/install_sqlsrv.sh Outdated Show resolved Hide resolved
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Copy link
Member Author

gsteel commented May 8, 2024

When did they change artifacts?

I have no idea - just saw that CI was failing 🤷‍♂️

@gsteel gsteel changed the title Attempt to fix installation of MSSQL extension Fix installation of MSSQL extension May 8, 2024
Co-authored-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: George Steel <george@netglue.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants