-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation of MSSQL extension #235
Open
gsteel
wants to merge
3
commits into
laminas:1.40.x
Choose a base branch
from
gsteel:fix-ms-sql-install
base: 1.40.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
force-pushed
the
fix-ms-sql-install
branch
2 times, most recently
from
May 8, 2024 09:29
7dc4aa8
to
ff46fa3
Compare
Xerkus
reviewed
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When did they change artifacts?
Signed-off-by: George Steel <george@net-glue.co.uk>
I have no idea - just saw that CI was failing 🤷♂️ |
gsteel
changed the title
Attempt to fix installation of MSSQL extension
Fix installation of MSSQL extension
May 8, 2024
Xerkus
reviewed
May 8, 2024
Co-authored-by: Aleksei Khudiakov <aleksey@xerkus.pro> Signed-off-by: George Steel <george@netglue.uk> Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI is currently failing - looks like the asset locations are incorrect for https://github.com/microsoft/msphpsql/releases/tag/v5.12.0