Bump MSRV to 1.36 #48
Merged
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
added a commit
to sunfishcode/caps-rs
that referenced
this pull request
Jul 4, 2022
Would you be willing to bump caps' MSRV to 1.48, so that [rust-errno] can migrate from winapi to windows-sys? This will eliminate the last winapi dependency for rustix and some of its users. windows-sys depends on at least Rust 1.48, so this will require bumping rust-errno's MSRV. caps is [one of rust-errno's biggest users]. Last time cap's bumped its MSRV was lucab#46 on 2020-01-09, bumping to Rust 1.36, which was released on 2019-07-04, so it was about 6 months old at that point. Rust 1.48 was released on 2020-11-19, which is now about a year and a half old now. caps is depended on nix with an MSRV of 1.46, however it is only a dev-dependency. [rust-errno]: https://github.com/lambda-fairy/rust-errno [one of rust-errno's biggest users]: lambda-fairy/rust-errno#48
sunfishcode
added a commit
to sunfishcode/caps-rs
that referenced
this pull request
Jul 4, 2022
Would you be willing to bump caps' MSRV to 1.48, so that [rust-errno] can migrate from winapi to windows-sys? This isn't urgent, but if it works out, it would eliminate the last winapi dependency for rustix and some of its users, so I figured it's worth asking. windows-sys depends on at least Rust 1.48, so this will require bumping rust-errno's MSRV. caps is [one of rust-errno's biggest users]. Last time cap's bumped its MSRV was lucab#46 on 2020-01-09, bumping to Rust 1.36, which was released on 2019-07-04, so it was about 6 months old at that point. Rust 1.48 was released on 2020-11-19, which is now about a year and a half old now. caps is depended on nix with an MSRV of 1.46, however it is only a dev-dependency. [rust-errno]: https://github.com/lambda-fairy/rust-errno [one of rust-errno's biggest users]: lambda-fairy/rust-errno#48
sunfishcode
added a commit
to sunfishcode/caps-rs
that referenced
this pull request
Jul 4, 2022
Would you be willing to bump caps' MSRV to 1.48, so that [rust-errno] can migrate from winapi to windows-sys? This isn't urgent, but if it works out, it would eliminate the last winapi dependency for rustix and some of its users, so I figured it's worth asking. windows-sys depends on at least Rust 1.48, so this will require bumping rust-errno's MSRV. caps is [one of rust-errno's biggest users]. Last time cap's bumped its MSRV was lucab#46 on 2020-01-09, bumping to Rust 1.36, which was released on 2019-07-04, so it was about 6 months old at that point. Rust 1.48 was released on 2020-11-19, which is about a year and a half old now. caps is depended on nix with an MSRV of 1.46, however it is only a dev-dependency. [rust-errno]: https://github.com/lambda-fairy/rust-errno [one of rust-errno's biggest users]: lambda-fairy/rust-errno#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.36 is the earliest version that supports
Iterator::copied.Per #44 (comment), Rust 1.36 should be okay with our biggest dependents
capsandrustix.Fixes #47