Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TestAgent): update superagent's Agent instantiation due to was cl… #836

Closed
wants to merge 2 commits into from
Closed

fix(TestAgent): update superagent's Agent instantiation due to was cl… #836

wants to merge 2 commits into from

Conversation

Santiagomrn
Copy link

@Santiagomrn Santiagomrn commented Apr 24, 2024 •
edited

#833

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@titanism
Copy link
Collaborator

Closing in favor of #834 - if you had thoughts/argument as to why your approach is better please let us know

@titanism titanism closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Santiagomrn @titanism