Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease - v5.0.0-0 #601

Merged
merged 3 commits into from Oct 2, 2019
Merged

Prerelease - v5.0.0-0 #601

merged 3 commits into from Oct 2, 2019

Conversation

rimiti
Copy link
Contributor

@rimiti rimiti commented Oct 2, 2019

Purpose

  • Eslint compliant: 'use strict' added into all files
  • Packages updated + versions fixed
  • Test are now running in lts node version

Related

Note

This PR will be released in alpha in order to be tested by their users before being officially released.

The superagent update can be potentially dangerous (two versions bumped).

How to install this version

yarn add supertest@5.0.0-0 -D

Or

npm i  supertest@5.0.0-0 --save-dev

@coveralls
Copy link

coveralls commented Oct 2, 2019

Pull Request Test Coverage Report for Build 429

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.297%

Totals Coverage Status
Change from base Build 421: 0.0%
Covered Lines: 137
Relevant Lines: 141

💛 - Coveralls

@rimiti
Copy link
Contributor Author

rimiti commented Oct 2, 2019

A special thanks to @bajtos to having providing the superagent PR: ladjs/superagent#1468. 🙏

@rimiti rimiti merged commit ed9d49f into master Oct 2, 2019
@rimiti rimiti deleted the pre-release branch October 2, 2019 10:44
@rimiti rimiti self-assigned this Oct 2, 2019
@rimiti rimiti added this to the v5.0.0-0 milestone Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants