New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct urls using `url.format()` #569

Closed

tprobinson wants to merge 1 commit into ladjs:master from tprobinson:normalize-url-parsing

tprobinson commented Mar 29, 2019

This fixes strange errors when the requested path does not begin with a slash.

Also fix a test that wouldn't work by using os.hostname() to create a localhost-like name.


          Construct urls using url.format()

2b05540

Also fix a test that wouldn't work

coveralls commented Mar 29, 2019 •

edited

Pull Request Test Coverage Report for Build 406

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 97.309%

Totals
Change from base Build 404:	0.01%
Covered Lines:	138
Relevant Lines:	142

💛 - Coveralls

Author

tprobinson commented Jul 17, 2019

Closed in favor of #580

tprobinson closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment