Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const and let instead of var #510

Merged
merged 4 commits into from Sep 6, 2018
Merged

Use const and let instead of var #510

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7233ba6
chore(.eslintrc) parserOptions option added to use es6
rimiti Sep 5, 2018
5443136
chore(.editorconfig) configuration file created
rimiti Sep 5, 2018
82e0828
refact(test/supertest.js) vars replaced by const and let
rimiti Sep 5, 2018
913150d
chore(.editorconfig) [*.md] block removed
rimiti Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions .editorconfig
View file
Open in desktop
@@ -0,0 +1,16 @@
root = true

[*]
charset = utf-8
insert_final_newline = true
end_of_line = lf
trim_trailing_whitespace = true
indent_style = space
indent_size = 2

[*.{js,json}]
indent_size = 2
indent_style = space

[*.md]
insert_final_newline = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rimiti I think we should still insert final newlines even for md files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, ok! I fix it

3 changes: 3 additions & 0 deletions .eslintrc
View file
Open in desktop
Expand Up @@ -4,6 +4,9 @@
"node": true,
"mocha": true
},
"parserOptions": {
"ecmaVersion": 6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rimiti what is the difference between using this parser option and adding es6: true to the env attribute?

},
"rules": {
// disabled - disagree with airbnb
"func-names": [0],
Expand Down