Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tinyify to 4.x #1747

Closed
wants to merge 1 commit into from
Closed

Conversation

lorand-horvath
Copy link

Should fix #1743

@titanism
Copy link
Collaborator

I've tested and this doesn't seem to fix the issue. I'm still trying to investigate and see what's wrong. Help is welcome.

@titanism
Copy link
Collaborator

Ah- I found the culprit - it's the minify npm script which is causing the issue. So most likely browserify/tinyify are the culprits as we suspect. I'm going to try version locking and such and see if that resolves.

@titanism
Copy link
Collaborator

This is related to browserify/common-shakeify#41 and browserify/common-shakeify#42

@titanism titanism closed this in 63340fa Oct 24, 2022
@titanism
Copy link
Collaborator

v8.0.3 released to npm 🎉 !!

the issue was tinyify, which bumped common-shakeify, and has a few underlying issues that need resolved before we can upgrade it. apologies for the delay, this wasn't easy to track down.

https://github.com/visionmedia/superagent/releases/tag/v8.0.3

@titanism
Copy link
Collaborator

To anyone reading, tinyify still seems to have issues on 4.x and > 3.0.0 versions. If anyone wants to dig in, please do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require is not defined on vanilla js
2 participants