Fix xml tests that broke with mime update #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
focusaurus
force-pushed
the
fix-latest-mime-tests
branch
from
c0b3391
to
0173a9d
Compare
|
Looks like mime 1.3.4 had |
PWesterdale
pushed a commit
to PWesterdale/superagent
that referenced
this pull request
May 18, 2017
|
@pornel Thoughts on this? I confirmed it was mime 1.3.6 that introduced this change. /tmp/20170524-100433 -> npm i mime@1.3.5
mime@1.3.5 node_modules/mime
/tmp/20170524-100433 -> node
> require('mime').types.xml
'application/xml'
/tmp/20170524-100433 -> npm i mime@1.3.6
mime@1.3.6 node_modules/mime
/tmp/20170524-100433 -> node
> require('mime').types.xml
'text/xml'I did some github research trying to understand the back story for this change but the rabbit hole got the best of me. |
|
Also FYI I asked for help here: broofa/mime#158 I see no mention of this change in the mime-db history file: https://github.com/jshttp/mime-db/blob/master/HISTORY.md I'm a bit perplexed at this point. Hopefully someone closer to the issue might shed some light so we can merge this and get the tests passing again. |
kornelski
added a commit
that referenced
this pull request
Aug 8, 2017
* commit '4e21f1c509c3ee09ea4031c27855ed8e9ddc0d35': Documented FormData support in .send() (#1260) Update supported node version to >= 4.0 (#1248) Keep nodelay always on support TCP_NODELAY option (#1240) timeout options.read property is not used. grammar misstype (#1234) Fix spelling mistake in the docs (#1232) Revert test 'fixes' - see PR #1227 Support passphrase with pfx certificate Fix build errors Send payload in query string for GET and HEAD shorthand API Fix xml tests that broke with mime update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.