You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
@ungrim97 Well I think your syntax was right, but eslint didn't parse engines properly so it was giving me an error. The simpler fix was to just do >= 6.4 !13, since all we wanted to do was exclude v13 entirely. This version without the || seemed to pass with eslint. See discussion here mysticatea/eslint-plugin-node#315.
d442ae1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually doesn't fix it, it causes another issue, I think our syntax is still wrong
d442ae1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a space before and after the
||. Testing now.d442ae1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v7.0.1 released https://github.com/visionmedia/superagent/releases/tag/v7.0.1
d442ae1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niftylettuce by wrong do you mean it still wouldn't install or that it wouldn't correctly apply the range?
I assume the latter based on your change
d442ae1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ungrim97 Well I think your syntax was right, but
eslintdidn't parseenginesproperly so it was giving me an error. The simpler fix was to just do>= 6.4 !13, since all we wanted to do was exclude v13 entirely. This version without the||seemed to pass witheslint. See discussion here mysticatea/eslint-plugin-node#315.