Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware): add Deflate middleware #2085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

masakichi
Copy link

Add Deflate middleware which is very similar to the current Gzip middleware's implementation, I think it will be nice to have deflate as well if someone also needs it.

I didn't change any public function and struct in compress.go, and didn't touch existing test cases in compress_test.go as well, so I think this PR won't break backward compatibility.

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #2085 (6e6ae1e) into master (4a1ccdf) will decrease coverage by 0.02%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
- Coverage   92.21%   92.18%   -0.03%     
==========================================
  Files          37       37              
  Lines        3019     3034      +15     
==========================================
+ Hits         2784     2797      +13     
- Misses        148      150       +2     
  Partials       87       87              
Impacted Files Coverage Δ
middleware/compress.go 84.84% <88.00%> (+0.84%) ⬆️
ip.go 100.00% <0.00%> (ø)
echo.go 95.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a1ccdf...6e6ae1e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant