Split XFF header only by comma

labstack · May 20, 2021 · 04f8493 · 04f8493
1 parent 2acb24a
commit 04f8493
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/context.go b/context.go
@@ -276,9 +276,9 @@ func (c *context) RealIP() string {
 	}
 	// Fall back to legacy behavior
 	if ip := c.request.Header.Get(HeaderXForwardedFor); ip != "" {
-		i := strings.IndexAny(ip, ", ")
+		i := strings.IndexAny(ip, ",")
 		if i > 0 {
-			return ip[:i]
+			return strings.TrimSpace(ip[:i])
 		}
 		return ip
 	}

diff --git a/context_test.go b/context_test.go
@@ -888,6 +888,14 @@ func TestContext_RealIP(t *testing.T) {
 			},
 			"127.0.0.1",
 		},
+		{
+			&context{
+				request: &http.Request{
+					Header: http.Header{HeaderXForwardedFor: []string{"127.0.0.1,127.0.1.1"}},
+				},
+			},
+			"127.0.0.1",
+		},
 		{
 			&context{
 				request: &http.Request{