Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container commit not working on Docker 23 #2040

Merged
merged 2 commits into from Apr 22, 2024

Conversation

kyujin-cho
Copy link
Member

@kyujin-cho kyujin-cho commented Apr 22, 2024

Follow-up of #1973. Fixed container feature not working on agents interacting with Docker Engine 23 or 24.0.0 by appending config body without any meaning so that it can bypass issue moby/moby#45543.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@kyujin-cho kyujin-cho self-assigned this Apr 22, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Apr 22, 2024
@kyujin-cho kyujin-cho added type:bug Reports about that are not working and removed size:S 10~30 LoC labels Apr 22, 2024
@kyujin-cho kyujin-cho added this to the 24.03 milestone Apr 22, 2024
@kyujin-cho kyujin-cho added type:bug Reports about that are not working comp:agent Related to Agent component size:S 10~30 LoC and removed type:bug Reports about that are not working labels Apr 22, 2024
@achimnol achimnol added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit f08911e Apr 22, 2024
33 of 41 checks passed
@achimnol achimnol deleted the fix/commit-not-working-docker-23 branch April 22, 2024 16:29
achimnol pushed a commit that referenced this pull request Apr 22, 2024
Backported-from: main (24.09)
Backported-to: 24.03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants