Fix typing issues of StringSetFlag #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Selectively ignore override errors as this is a custom class * Use a separate interface declaration file (.pyi) by refactoring out StringSetFlag class from the utils module to overcome limitation of mypy semantic analysis on "__ror__ = __or__" in subclasses of Enum/Flag classes.
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 75.75% 75.87% +0.11%
==========================================
Files 23 24 +1
Lines 3193 3196 +3
==========================================
+ Hits 2419 2425 +6
+ Misses 774 771 -3
Continue to review full report at Codecov.
|
achimnol
added a commit
that referenced
this pull request
Jan 5, 2022
* Selectively ignore override errors as this is a custom class * Use a separate interface declaration file (.pyi) by refactoring out StringSetFlag class from the utils module to overcome limitation of mypy semantic analysis on "__ror__ = __or__" in subclasses of Enum/Flag classes. Backported-From: main (22.03) Backported-To: 21.09
achimnol
added a commit
that referenced
this pull request
Jan 5, 2022
* Selectively ignore override errors as this is a custom class * Use a separate interface declaration file (.pyi) by refactoring out StringSetFlag class from the utils module to overcome limitation of mypy semantic analysis on "__ror__ = __or__" in subclasses of Enum/Flag classes. Backported-From: main (22.03) Backported-To; 21.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringSetFlag class from the utils module to overcome limitation of
mypy semantic analysis on
__ror__ = __or__in subclasses ofEnum/Flag classes.
(ref: 0.930 still gives me "inheriting final" error with an enum.Flag subclass python/mypy#11850 (comment))