Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: Comply with HTTP Headers standard allowing case insensitive headers #34

Merged
merged 1 commit into from Jun 6, 2021

Conversation

ljmf00
Copy link
Member

@ljmf00 ljmf00 commented Jun 6, 2021

@ljmf00 ljmf00 added bug Something isn't working trivial Easy to review and no breaking changes labels Jun 6, 2021
@ljmf00 ljmf00 requested a review from iK4tsu June 6, 2021 17:05
@iK4tsu
Copy link
Contributor

iK4tsu commented Jun 6, 2021

Codecov failed to connect. Try to force push or replace the secret with the same token. Codecov has some weird bugs sometimes.

@ljmf00
Copy link
Member Author

ljmf00 commented Jun 6, 2021

CC @mfrade @miguel-negrao @PatricioDomingues

Apparently, Codecov had security issues or is heisenberging 😠

https://about.codecov.io/security-update/
codecov/codecov-action#330

I'm not sure if we added Codecov before or after this, but we should, either way, rotate our tokens.

@ljmf00
Copy link
Member Author

ljmf00 commented Jun 6, 2021

Codecov failed to connect. Try to force push or replace the secret with the same token. Codecov has some weird bugs sometimes.

I wish codacy supported D, cof cof. Force pushed, hope it fixes this heisenberg problem, for now.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2021

Codecov Report

Merging #34 (e71d0b5) into main (50c8fba) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   19.28%   19.19%   -0.09%     
==========================================
  Files          19       19              
  Lines         223      224       +1     
==========================================
  Hits           43       43              
- Misses        180      181       +1     
Flag Coverage Δ
unittests 19.19% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/gboardforensics/gatherers/translatecache.d 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c8fba...e71d0b5. Read the comment docs.

@ljmf00 ljmf00 merged commit d053c4b into labcif:main Jun 6, 2021
@ljmf00 ljmf00 deleted the fix-issue-33 branch June 6, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working trivial Easy to review and no breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support case-insensitive HTTP headers
3 participants