Strip common path prefix

[ivan23kor]

Strip common path prefixes in test case names, generated with macro #files.

Implementation

After test file paths have been built relative to the base dir (CARGO_MANIFEST_DIR ), find the maximum common prefix for all test paths and remove this prefix from the test case names.

Example

rstest/tests/rstest/mod.rs demonstrates the gist of the change:

Common prefix _files is stripped from the paths:

-        .ok("start_with_name::path_1__UP_files_test_sub_folder_from_parent_folder_txt")
-        .ok("start_with_name::path_2_files_element_0_txt")
-        .ok("start_with_name::path_3_files_element_1_txt")
-        .ok("start_with_name::path_4_files_element_2_txt")
-        .ok("start_with_name::path_5_files_element_3_txt")
-        .ok("start_with_name::path_6_files_sub_sub_dir_file_txt")
-        .ok("start_with_name_with_include::path_1_files__ignore_me_txt")
-        .ok("start_with_name_with_include::path_2_files_element_0_txt")
-        .ok("start_with_name_with_include::path_3_files_element_1_txt")
-        .ok("start_with_name_with_include::path_4_files_element_2_txt")
-        .ok("start_with_name_with_include::path_5_files_element_3_txt")
-        .ok("start_with_name_with_include::path_6_files_sub_sub_dir_file_txt")
+        .ok("start_with_name::path_1_files_test_sub_folder_from_parent_folder_txt")
+        .ok("start_with_name::path_2_rstest_files_files_element_0_txt")
+        .ok("start_with_name::path_3_rstest_files_files_element_1_txt")
+        .ok("start_with_name::path_4_rstest_files_files_element_2_txt")
+        .ok("start_with_name::path_5_rstest_files_files_element_3_txt")
+        .ok("start_with_name::path_6_rstest_files_files_sub_sub_dir_file_txt")
+        .ok("start_with_name_with_include::path_1__ignore_me_txt")
+        .ok("start_with_name_with_include::path_2_element_0_txt")
+        .ok("start_with_name_with_include::path_3_element_1_txt")
+        .ok("start_with_name_with_include::path_4_element_2_txt")
+        .ok("start_with_name_with_include::path_5_element_3_txt")
+        .ok("start_with_name_with_include::path_6_sub_sub_dir_file_txt")

Details

1. Test cases for #files have been updated to expect common prefix stripped.
2. Minor refactoring: use a simple literal expression for path values instead of conversion expression between String and PathBuf in tests for #files.

Addresses #212.

[ivan23kor]

@la10736 I just noticed through local testing that 7e1f611 introduced unintended behaviour - it does not respect exclude glob. 278ccdc still works. I am currently debugging.

[ivan23kor]

@la10736 this is_valid applies the original glob pattern path to the truncated path, hence path exclusion will not work after prefix stripping. I will move is_valid check to before path stripping.

[ivan23kor]

Fixed it in 76671c7: I changed is_valid -> !is_excluded and moved is_excluded into find_paths, so find_paths now applies both include and exclude globs.

[la10736]

THX for this PR!! Really appreciated!
Sorry, I need some time for review it... but I'll do it ASAP...

[ivan23kor]

No rush and thank you for getting to reviewing it.