Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully qualify PathBuf in #[files] expansion #242

Merged
merged 2 commits into from Apr 15, 2024

Conversation

narpfel
Copy link
Contributor

@narpfel narpfel commented Apr 12, 2024

Otherwise PathBuf would have to be in scope where #[files] is used.

@narpfel
Copy link
Contributor Author

narpfel commented Apr 12, 2024

It seems the CI is a bit flaky?

@la10736
Copy link
Owner

la10736 commented Apr 12, 2024

Yes, you're right 😢
It's a concurrent issue that I was never able to reproduce on my side and I looked the code deeply and I didn't find any issue... maybe the CI instance is really slow that trigger this issue.

Copy link
Owner

@la10736 la10736 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX, can you add also a line in changelog file?

@narpfel
Copy link
Contributor Author

narpfel commented Apr 14, 2024

can you add also a line in changelog file?

Done and rebased onto master.

@la10736 la10736 self-requested a review April 15, 2024 07:53
Copy link
Owner

@la10736 la10736 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@la10736 la10736 merged commit 06a2117 into la10736:master Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants