Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo that prevented running the tests on beta and nightly #240

Merged
merged 2 commits into from Apr 9, 2024

Conversation

narpfel
Copy link
Contributor

@narpfel narpfel commented Apr 9, 2024

Environment variables are not visible in child processes unless they are set in the same command (or using export):

$ cat test.sh
#!/usr/bin/env bash

echo $SOME_ENV_VAR
$ SOME_ENV_VAR=hello ./test.sh
hello
$ SOME_ENV_VAR=hello; ./test.sh

$

Copy link
Owner

@la10736 la10736 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX!!!!
LGTM

@la10736 la10736 merged commit fca01ef into la10736:master Apr 9, 2024
2 checks passed
@narpfel narpfel deleted the actually-test-beta-and-nightly branch April 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants