Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: document cfg_attr for cases #236

Merged
merged 2 commits into from Apr 5, 2024
Merged

README: document cfg_attr for cases #236

merged 2 commits into from Apr 5, 2024

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 2, 2024

Fixes #234.

@flokli flokli mentioned this pull request Apr 2, 2024
Closed
la10736
la10736 requested changes Apr 3, 2024
View reviewed changes
Copy link
Owner

@la10736 la10736 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX!, Can you also add the docs to rstest procedural macro function in rstest_macro crate?

@flokli
Copy link
Contributor Author

flokli commented Apr 5, 2024

Done!

@flokli flokli requested a review from la10736 April 5, 2024 10:42
la10736
la10736 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@la10736 la10736 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! THX

@la10736 la10736 merged commit e03fed3 into la10736:master Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@la10736 la10736 la10736 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip cases based on feature flag?
2 participants
@flokli @la10736