Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syn update and 2021 #188

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Syn update and 2021 #188

merged 4 commits into from
Mar 20, 2023

Conversation

la10736
Copy link
Owner

@la10736 la10736 commented Mar 20, 2023

Fix #187

@la10736 la10736 merged commit 2f1ff25 into master Mar 20, 2023
@LikeLakers2
Copy link

LikeLakers2 commented Mar 21, 2023

Hey, since you mention the MSRV in the changelog, may I suggest documenting that elsewhere?

If nothing else, I would suggest using Cargo.toml's rust-version field. This is a field added in Rust 1.56 (which is your MSRV, and additionally is the first version to support edition = "2021"), which Cargo will parse upon trying to build your crate - and will exit with an error should the current Rust version not be at least that version.

@la10736 la10736 deleted the syn_update_and_2021 branch April 8, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider updating rstest_macros to use Syn v2
2 participants