fix: use official controller-gen #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
| @@ -10,7 +10,7 @@ GIT_BRANCH := $(shell git branch | grep \* | cut -d ' ' -f2) | |||
| GIT_HASH := $(GIT_BRANCH)/$(shell git log -1 --pretty=format:"%H") | |||
| TIMESTAMP := $(shell date '+%Y-%m-%d_%I:%M:%S%p') | |||
| CONTROLLER_GEN=controller-gen | |||
| CONTROLLER_GEN_REQ_VERSION := v0.8.0 | |||
| CONTROLLER_GEN_REQ_VERSION := v0.9.1-0.20220629131006-1878064c4cdf | |||
There was a problem hiding this comment.
Looks like changes has not included/cherry-picked in latest release 0.9.2 ?
There was a problem hiding this comment.
@prateekpandey14 I need to cherry pick my changes so that they are included in the next release.
Until then it's still better to use the official repo than my fork IMHO.
prateekpandey14
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches back to the official controller-gen repo now kubernetes-sigs/controller-tools#683 was merged.