Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: used typed admission request in ur #4022

Merged
merged 9 commits into from May 29, 2022
Merged

refactor: used typed admission request in ur #4022

merged 9 commits into from May 29, 2022

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented May 25, 2022

revival

Looks like there's an issue in controller-tools, opened kubernetes-sigs/controller-tools#683 馃

Signed-off-by: Charles-Edouard Br茅t茅ch茅 <charled.breteche@gmail.com>
(cherry picked from commit cd1fa03)
Signed-off-by: Charles-Edouard Br茅t茅ch茅 <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Br茅t茅ch茅 <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Br茅t茅ch茅 <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Br茅t茅ch茅 <charled.breteche@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #4022 (c1cd96f) into main (7245c92) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #4022   +/-   ##
=======================================
  Coverage   29.49%   29.50%           
=======================================
  Files         138      138           
  Lines       18462    18458    -4     
=======================================
  Hits         5446     5446           
+ Misses      12353    12349    -4     
  Partials      663      663           
Impacted Files Coverage 螖
pkg/webhooks/resource/utils.go 20.63% <0.00%> (+0.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7245c92...c1cd96f. Read the comment docs.

@eddycharly eddycharly marked this pull request as ready for review May 25, 2022 20:41
Makefile Show resolved Hide resolved
cmd/initContainer/main.go Outdated Show resolved Hide resolved
config/crds/kyverno.io_generaterequests.yaml Show resolved Hide resolved
pkg/background/update_request_controller.go Outdated Show resolved Hide resolved
pkg/webhooks/updaterequest/generator.go Outdated Show resolved Hide resolved
vyankyGH and others added 2 commits May 26, 2022 09:44
Signed-off-by: Charles-Edouard Br茅t茅ch茅 <charled.breteche@gmail.com>
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting realshuting enabled auto-merge (squash) May 29, 2022 07:08
@realshuting realshuting merged commit dae3dad into kyverno:main May 29, 2022
realshuting pushed a commit to realshuting/kyverno that referenced this pull request May 29, 2022
Signed-off-by: ShutingZhao <shuting@nirmata.com>
vyankyGH pushed a commit that referenced this pull request May 30, 2022
* Cherry-pick #4022

Signed-off-by: ShutingZhao <shuting@nirmata.com>

* Remove unused file
@realshuting realshuting added the release notes This label is added to the PR without a corresponding issue. It is used to create release notes. label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milestone 1.7.0 release notes This label is added to the PR without a corresponding issue. It is used to create release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants