New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove data_type from column proto #1468

Merged

kyleconroy merged 1 commit into sqlc-dev:main from stephen:datatype-refactor

Mar 2, 2022

Contributor

stephen commented Mar 2, 2022

The information is duplicated from Column.type

See #1460 (comment)

DataType is never filled in so this comparison is buggy. This change mirrors
what the go gen.go does instead.

Deleting a field from proto can be not safe for compat, so we could use
https://developers.google.com/protocol-buffers/docs/proto3#reserved,
but I think these protos are transient so it should be ok.


          fix bug where datatype is read from

2cec58a

See sqlc-dev#1460 (comment)

DataType is never filled in so this comparison is buggy. This change mirrors
what the go gen.go does instead.

Deleting a field from proto can be not safe for compat, so we could use
https://developers.google.com/protocol-buffers/docs/proto3#reserved,
but I think these protos are transient so it should be ok.

stephen changed the title ~~Remove data_type from columnn proto~~ Remove data_type from column proto

kyleconroy approved these changes

View reviewed changes

Collaborator

kyleconroy left a comment

The proto hasn't been published, so we can make as many changes as we want for now.

kyleconroy merged commit eb640c8 into sqlc-dev:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment