M123 public #234
Merged
M123 public #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvaskit/0.38.2-3316-g982874994d)
SkTypeface::MakeFromName is gone
SkTypeface::MakeFromFile also gone
SkTypeface::MakeFromData is gone
New lastResortMgr argument to SkTypeface::MakeDeserialize
Milestone 122
-------------
* `SkFontMgr::RefDefault()` has been deleted. Clients should instantiate and manage their own
`SkFontMgr`s and use them to explicitly create `SkTypeface`s
Fixes kyamagu#231
Adapted from
chromium/chromium@a6166e8
The FontConfigInterface version somehow segfaults.
… failure Upstream problem reported at pypa/cibuildwheel#1740 .
…994d to canvaskit/0.38.2-3317-gc6835e2d5f
…anvaskit/0.38.2-3701-gaeae2261c7)
See google/skia@64e67c3 "Remove deprecated getBlendMode" for how this emulation is inspired. Fixes kyamagu#235 drop const in function prototype.
…3702-g3d4e45907f on m123
The macOS detector macro is called `__APPLE__`, not `__apple__`
|
Last: 2085 passed, 97 skipped, 11 xfailed, 27 warnings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kyamagu good news: there is no python-side change needed between m122 and m123. So there is only changes in skia version and corresponding adjustments. Since this has no advantage over m121, I'd suggest not merging this until we have something interesting besides version changes, e.g. we fixes a few more tests, or somebody files a bug. Just FYI.
I am definitely having second thought about the COLRv1 patch. So if I disappear, please feel free to drop it. I will also experiment with a "try removing ..." and revert at some point to make sure it can be removed in one single commit.