Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Commit

Permalink
Pin Jekyll version to 4.0.0 (vs 4.0), because 4.0 also matches 4.0.1,…
Browse files Browse the repository at this point in the history
… which introduced a speed regression jekyll/jekyll#8233 /cc @nqst
  • Loading branch information
kvz committed Jun 9, 2020
1 parent 21a3f16 commit c8f299c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
## master

Released: TBA.
[Diff](https://github.com/kvz/lanyon/compare/v0.2.19...master).
[Diff](https://github.com/kvz/lanyon/compare/v0.2.20...master).

- [ ] Add a 'real' command line parser for `lib/cli.js` like minimist
- [ ] Fix bug where failed deploy is not fatal: https://travis-ci.org/kvz/invig/builds/202931498#L627
Expand All @@ -21,6 +21,13 @@ Released: TBA.
- [ ] Throw warning when not jekyll excluding: `- node_modules - .git`, like when you have `exclude: [vendor]` in your jekyll config
- [ ] Incorporate hacks in tus.io .lanyonrc, it should be able to run with an empty rc, except for hook

## v0.2.20

Released: 2020-06-09
[Diff](https://github.com/kvz/lanyon/compare/v0.2.19...v0.2.20).

- [x] Pin Jekyll version to 4.0.0 (vs 4.0), because 4.0 also matches 4.0.1, which introduced a speed regression https://github.com/jekyll/jekyll/issues/8233

## v0.2.19

Released: 2020-06-09
Expand Down
2 changes: 1 addition & 1 deletion container/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# https://rubygems.org/gems/jekyll-last-modified-at
# https://rubygems.org/gems/jekyll-redirect-from

FROM jekyll/jekyll:4.0
FROM jekyll/jekyll:4.0.0
RUN gem install \
jekyll-archives:2.2.1 \
stringex:2.8.5 \
Expand Down

2 comments on commit c8f299c

@iBug
Copy link

@iBug iBug commented on c8f299c Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid you misunderstood jekyll/jekyll#8233 as the performance issue is with 4.1.0. On the other hand 4.0.1 has some important bug fixes to 4.0.0 that may be demanded in many cases.

@kvz
Copy link
Owner Author

@kvz kvz commented on c8f299c Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooohhhh, thank you!

Please sign in to comment.