Fix #459 - Check inner type of the scalar list #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziima
force-pushed
the
scalar-list-check-input
branch
from
e2bd145
to
99d0a11
Compare
ziima
force-pushed
the
scalar-list-check-input
branch
from
99d0a11
to
583adb8
Compare
kvesteri
requested changes
Jul 10, 2020
| """ | ||
|
|
||
| impl = sa.UnicodeText() | ||
|
|
||
| def __init__(self, coerce_func=six.text_type, separator=u','): | ||
| def __init__(self, inner_type=six.text_type, separator=u',', |
There was a problem hiding this comment.
Why not keeping the parameter order as it was and adding the new parameter as the last parameter? That way we wouldn't need to throw any warnings.
There was a problem hiding this comment.
I was thinking about that. I believe, having inner_type defined is the only way I can ensure validation of the values before they're written to database. So I made inner_type primary and coerce_func optional. It would be weird to have an optional parameter first.
There was a problem hiding this comment.
@kvesteri Any decision?
There was a problem hiding this comment.
@kvesteri I'd like to move this forward. Can I keep the change, or should I add the inner_type as the last parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complex fix for #459. I've changed the first argument of
ScalarListTypeto a type of its values, since in most cases it's the same ascoerce_func. All values are checked if they match the type on save. Backwards compatibility is maintained.