Check for SQLite header in database_exists
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with this change, `create_database` will also create an actual SQLite database file instead of just an empty file.
kvesteri
reviewed
Dec 3, 2018
| @@ -567,7 +576,8 @@ def create_database(url, encoding='utf8', template=None): | |||
|
|
|||
| elif engine.dialect.name == 'sqlite' and database != ':memory:': | |||
| if database: | |||
| open(database, 'w').close() | |||
| engine.execute("CREATE TABLE DB(id int);") | |||
There was a problem hiding this comment.
This and the line below seem strange. What is their purpose?
There was a problem hiding this comment.
It is so an actual SQLite file is created instead of just an empty file.
|
Thanks for the PR! 🚋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with this change,
create_databasewill also create an actualSQLite database file instead of just an empty file.
Fixes #306