Parametrize script runner with indirect=True
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for the PR. It seems that the test suite is broken because of changes to |
|
It seems that they have reverted the changes in the API (changelog, ticket) so this change is no longer necessary. Anyway, thanks for the PR -- it motivated me to fix the tests so they now work with the latest version of virtualenv (#31). I'm leaning towards merging this PR anyway since it doesn't have any downsides and makes it work with pytest 5.4.0. What do you think? |
|
Might as well; I don't think the |
This change is needed for pytest 5.4.0 c.f. pytest-dev/pytest#5712
|
Yeah, makes sense. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed for pytest 5.4.0
c.f. pytest-dev/pytest#5712