Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: esm support #16

Merged
merged 1 commit into from Nov 27, 2022
Merged

feat: esm support #16

merged 1 commit into from Nov 27, 2022

Conversation

dangreen
Copy link
Contributor

@dangreen dangreen commented Nov 25, 2022 •
edited

Need to solve chartjs/Chart.js#10917

@dangreen
Copy link
Contributor Author

@kurkle review pls 🙏

kurkle
kurkle previously approved these changes Nov 27, 2022
View reviewed changes
Copy link
Owner

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kurkle
Copy link
Owner

kurkle commented Nov 27, 2022

Except some dependency issues, at least typedoc needs to be updated.

@dangreen
Copy link
Contributor Author

@kurkle done

@kurkle kurkle merged commit 7023fb3 into kurkle:master Nov 27, 2022
@dangreen dangreen deleted the feat-esm branch November 27, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dangreen @kurkle