Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(golangci-lint): update to v1.55.2, skip package cache #8820

Merged
merged 3 commits into from
Jan 12, 2024
Merged

ci(golangci-lint): update to v1.55.2, skip package cache #8820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fd0078
ci(golangci-lint): update to v1.55.2
michaelbeaumont Jan 11, 2024
d3f8762
skip pkg cache
lahabana Jan 12, 2024
0d85411
fix new issues
lahabana Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-test-distribute.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ jobs:
- uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
with:
args: --fix=false --verbose
version: v1.54.1
version: v1.55.2
skip-pkg-cache: true
- run: |
make clean
- run: |
Expand Down
2 changes: 1 addition & 1 deletion mk/dependencies/deps.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a576bd0d7a0f15ce1905d50613193ee847611b67
2ba2dc429cb050355e7039e307399bf99cfb56b4
2 changes: 1 addition & 1 deletion mk/dev.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ CI_TOOLS_BIN_DIR=$(CI_TOOLS_DIR)/bin
K8S_MIN_VERSION = v1.23.17-k3s1
K8S_MAX_VERSION = v1.28.1-k3s1
export GO_VERSION=$(shell go mod edit -json | jq -r .Go)
export GOLANGCI_LINT_VERSION=v1.54.1
export GOLANGCI_LINT_VERSION=v1.55.2
GOOS := $(shell go env GOOS)
GOARCH := $(shell go env GOARCH)

Expand Down
4 changes: 3 additions & 1 deletion pkg/plugins/policies/meshfaultinjection/api/v1alpha1/validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ func validateTo(topTargetRef common_api.TargetRef, to []To) validators.Validatio
func validateDefault(path validators.PathBuilder, conf Conf) validators.ValidationError {
var verr validators.ValidationError
path = path.Field("http")
for idx, fault := range pointer.Deref(conf.Http) {
cfg := pointer.Deref(conf.Http)
for idx := range cfg {
fault := cfg[idx]
if fault.Abort != nil {
path := path.Field("abort").Index(idx)
verr.Add(validators.ValidateStatusCode(path.Field("httpStatus"), fault.Abort.HttpStatus))
Expand Down
1 change: 1 addition & 0 deletions pkg/test/resources/samples/global_secret_samples.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"github.com/kumahq/kuma/pkg/test/resources/builders"
)

//nolint:gosec
const SampleSigningKeyValue = `-----BEGIN RSA PRIVATE KEY-----
MIIEowIBAAKCAQEA2hVWqy1JzpbMEIrTr2UTdEsCMrTaUhAqZlhNLJrS8kc0mbPK
Z7nT1JErJGUI4/NRHSQQZND3biPEcVktu0P5Ui6Ieum8HH7ENoRaSwLgaV451LOG
Expand Down
2 changes: 1 addition & 1 deletion pkg/test/store/store_test_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func ExecuteStoreTests(
Expect(resource.Meta.GetName()).To(Equal(name))
Expect(resource.Meta.GetMesh()).To(Equal(mesh))
Expect(resource.Meta.GetVersion()).ToNot(BeEmpty())
Expect(resource.Meta.GetCreationTime().Unix()).ToNot(Equal(0))
Expect(resource.Meta.GetCreationTime()).ToNot(BeZero())
Expect(resource.Meta.GetCreationTime()).To(Equal(resource.Meta.GetModificationTime()))
Expect(resource.Meta.GetLabels()).To(HaveKeyWithValue("foo", "bar"))
Expect(resource.Spec).To(MatchProto(created.Spec))
Expand Down