ci(golangci-lint): update to v1.55.2, skip package cache (#8820)

* ci(golangci-lint): update to v1.55.2 * skip pkg cache Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Charly Molter <charly.molter@konghq.com> Co-authored-by: Charly Molter <charly.molter@konghq.com>
kumahq · Jan 12, 2024 · cd256f4 · cd256f4
1 parent dace74a
commit cd256f4
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/build-test-distribute.yaml b/.github/workflows/build-test-distribute.yaml
@@ -38,7 +38,8 @@ jobs:
       - uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
         with:
           args: --fix=false --verbose
-          version: v1.54.1
+          version: v1.55.2
+          skip-pkg-cache: true
       - run: |
           make clean
       - run: |

diff --git a/mk/dependencies/deps.lock b/mk/dependencies/deps.lock
@@ -1 +1 @@
-a576bd0d7a0f15ce1905d50613193ee847611b67
+2ba2dc429cb050355e7039e307399bf99cfb56b4
diff --git a/mk/dev.mk b/mk/dev.mk
@@ -24,7 +24,7 @@ CI_TOOLS_BIN_DIR=$(CI_TOOLS_DIR)/bin
 K8S_MIN_VERSION = v1.23.17-k3s1
 K8S_MAX_VERSION = v1.28.1-k3s1
 export GO_VERSION=$(shell go mod edit -json | jq -r .Go)
-export GOLANGCI_LINT_VERSION=v1.54.1
+export GOLANGCI_LINT_VERSION=v1.55.2
 GOOS := $(shell go env GOOS)
 GOARCH := $(shell go env GOARCH)
 

diff --git a/pkg/plugins/policies/meshfaultinjection/api/v1alpha1/validator.go b/pkg/plugins/policies/meshfaultinjection/api/v1alpha1/validator.go
@@ -74,7 +74,9 @@ func validateTo(topTargetRef common_api.TargetRef, to []To) validators.Validatio
 func validateDefault(path validators.PathBuilder, conf Conf) validators.ValidationError {
 	var verr validators.ValidationError
 	path = path.Field("http")
-	for idx, fault := range pointer.Deref(conf.Http) {
+	cfg := pointer.Deref(conf.Http)
+	for idx := range cfg {
+		fault := cfg[idx]
 		if fault.Abort != nil {
 			path := path.Field("abort").Index(idx)
 			verr.Add(validators.ValidateStatusCode(path.Field("httpStatus"), fault.Abort.HttpStatus))

diff --git a/pkg/test/resources/samples/global_secret_samples.go b/pkg/test/resources/samples/global_secret_samples.go
@@ -5,6 +5,7 @@ import (
 	"github.com/kumahq/kuma/pkg/test/resources/builders"
 )
 
+//nolint:gosec
 const SampleSigningKeyValue = `-----BEGIN RSA PRIVATE KEY-----
 MIIEowIBAAKCAQEA2hVWqy1JzpbMEIrTr2UTdEsCMrTaUhAqZlhNLJrS8kc0mbPK
 Z7nT1JErJGUI4/NRHSQQZND3biPEcVktu0P5Ui6Ieum8HH7ENoRaSwLgaV451LOG

diff --git a/pkg/test/store/store_test_template.go b/pkg/test/store/store_test_template.go
@@ -85,7 +85,7 @@ func ExecuteStoreTests(
 				Expect(resource.Meta.GetName()).To(Equal(name))
 				Expect(resource.Meta.GetMesh()).To(Equal(mesh))
 				Expect(resource.Meta.GetVersion()).ToNot(BeEmpty())
-				Expect(resource.Meta.GetCreationTime().Unix()).ToNot(Equal(0))
+				Expect(resource.Meta.GetCreationTime()).ToNot(BeZero())
 				Expect(resource.Meta.GetCreationTime()).To(Equal(resource.Meta.GetModificationTime()))
 				Expect(resource.Meta.GetLabels()).To(HaveKeyWithValue("foo", "bar"))
 				Expect(resource.Spec).To(MatchProto(created.Spec))