feature(dataplanes): adds matchers and origins to rules in panel #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
force-pushed
the
feature/matchers-in-panel
branch
from
5c56fe3
to
248f5ae
Compare
johncowen
force-pushed
the
feature/matchers-in-panel
branch
from
248f5ae
to
e92e61f
Compare
kleinfreund
reviewed
Mar 14, 2024
Signed-off-by: John Cowen <john.cowen@konghq.com>
johncowen
force-pushed
the
feature/matchers-in-panel
branch
from
e92e61f
to
29c2b83
Compare
Signed-off-by: John Cowen <john.cowen@konghq.com>
kleinfreund
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2287 for theThis is now mergedObject.groupBypolyfill.Adds matchers and origins to the rules in the summary panel for sidecar inbounds.
Likely to be some design amends as a follow up.