Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): compute cache key without reading package.json #1893

Merged
merged 1 commit into from
Aug 23, 2020
Merged

refactor(config): compute cache key without reading package.json #1893

merged 1 commit into from
Aug 23, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Aug 22, 2020

Summary

It is not necessary to get all dependencies' versions in package.json for computing cache key. This PR is to remove the getting project's dependencies from computing cache key.

Closes #1892

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5684

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.189%

Totals Coverage Status
Change from base Build 5683: 0.2%
Covered Lines: 1067
Relevant Lines: 1099

💛 - Coveralls

@ahnpnl ahnpnl merged commit 4875a58 into kulshekhar:master Aug 23, 2020
@ahnpnl ahnpnl deleted the cache-key branch August 23, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants