Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cumprod #419

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add support for cumprod #419

wants to merge 4 commits into from

Conversation

DenisVieriu97
Copy link
Collaborator

  • Add support for cumprod.
  • Extend cumsum testcase to test cumprod.

razarmehr
razarmehr approved these changes Apr 18, 2023
View reviewed changes
Copy link

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razarmehr
Copy link

There's this failure though on MacOS 12.5:
test_output_match_masked_cumprod_cpu_uint8

kulinseth
kulinseth requested changes Apr 18, 2023
View reviewed changes
aten/src/ATen/native/mps/operations/UnaryOps.mm Show resolved Hide resolved
aten/src/ATen/native/mps/operations/UnaryOps.mm
}
return rc;
});
TORCH_IMPL_FUNC(cumprod_out_mps)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DenisVieriu97 , can you just go ahead and add , cummin and cummax as well ?

@DenisVieriu97
Copy link
Collaborator Author

There's this failure though on MacOS 12.5: test_output_match_masked_cumprod_cpu_uint8

I'll take a look

@Mr4k Mr4k mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@razarmehr razarmehr razarmehr approved these changes

@skotapati skotapati Awaiting requested review from skotapati

@Ronian526 Ronian526 Awaiting requested review from Ronian526

@ssaladis ssaladis Awaiting requested review from ssaladis

@shuhand0 shuhand0 Awaiting requested review from shuhand0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@DenisVieriu97 @razarmehr @kulinseth