Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buildURL error #101

Merged
merged 2 commits into from
May 29, 2023
Merged

fix: buildURL error #101

merged 2 commits into from
May 29, 2023

Conversation

mengqiuleo
Copy link
Contributor

@mengqiuleo mengqiuleo commented May 28, 2023

fix error: Missing "./lib/helpers/buildURL" export in "axios" package

@mengqiuleo
Copy link
Contributor Author

#99

@mengqiuleo
Copy link
Contributor Author

mengqiuleo commented May 28, 2023

@mengqiuleo
Copy link
Contributor Author

When using the axios 1.x version, typescript error for AxiosRequestConfig, axios/axios#5573

@mengqiuleo
Copy link
Contributor Author

All test cases have passed successfully.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #101 (fc0c0e2) into master (0b64fd7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head fc0c0e2 differs from pull request most recent head 5edfbbd. Consider uploading reports for the commit 5edfbbd to get more accurate results

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   97.33%   97.36%   +0.03%     
==========================================
  Files           5        5              
  Lines          75       76       +1     
  Branches       21       21              
==========================================
+ Hits           73       74       +1     
  Partials        2        2              
Impacted Files Coverage Δ
src/throttleAdapterEnhancer.ts 96.00% <100.00%> (ø)
src/utils/buildSortedURL.ts 100.00% <100.00%> (ø)

Copy link
Owner

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work~
But axios.getUri depends on axios 1.x, it's breaking change for who using axios 0.x, maybe we should publish a major version like 4.0 for axiso-extensions?

yarn.lock Outdated Show resolved Hide resolved
@mengqiuleo
Copy link
Contributor Author

Nice work~ But axios.getUri depends on axios 1.x, it's breaking change for who using axios 0.x, maybe we should publish a major version like 4.0 for axiso-extensions?

@kuitos, I've tested axios.getUri locally, it's compatible with axios 0.x, and I removed the code I originally added for ts type,it's not compatible,use @ ts-ignore to resolve ts type error.

@kuitos kuitos merged commit f023497 into kuitos:master May 29, 2023
2 checks passed
@kuitos
Copy link
Owner

kuitos commented May 29, 2023

Thanks for your nice work~

@onlywei
Copy link

onlywei commented Feb 24, 2024

Will this ever be published to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "./lib/helpers/buildURL" export in "axios" package
3 participants