-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: buildURL error #101
fix: buildURL error #101
Conversation
with axios 1.x, we can use |
When using the axios 1.x version, typescript error for |
All test cases have passed successfully. |
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 97.33% 97.36% +0.03%
==========================================
Files 5 5
Lines 75 76 +1
Branches 21 21
==========================================
+ Hits 73 74 +1
Partials 2 2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work~
But axios.getUri
depends on axios 1.x, it's breaking change for who using axios 0.x, maybe we should publish a major version like 4.0 for axiso-extensions?
@kuitos, I've tested |
Thanks for your nice work~ |
Will this ever be published to npm? |
fix error: Missing "./lib/helpers/buildURL" export in "axios" package