Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Storybook の builder を webpack5 に変更 #2628

Merged
merged 1 commit into from Jun 29, 2022

Conversation

wmoai
Copy link
Contributor

@wmoai wmoai commented Jun 28, 2022

Related URL

#2465

Overview

node 18 以降で動かそうとするとデフォルトの builder-webpack4 だとエラーが発生するため、builder-webpack5 に変更します

What I did

  • Storybook の builder を builder-webpack5 に変更

Capture

@wmoai wmoai self-assigned this Jun 28, 2022
@wmoai wmoai requested a review from a team as a code owner June 28, 2022 05:13
@wmoai wmoai requested review from yt-ymmt and yamish123 and removed request for a team June 28, 2022 05:13
@reg-suit
Copy link

reg-suit bot commented Jun 28, 2022

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for smarthr-ui ready!

Name Link
🔨 Latest commit d435100
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-ui/deploys/62ba8dec752e7e0009903f43
😎 Deploy Preview https://deploy-preview-2628--smarthr-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@yamish123 yamish123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regに差分が出ていたが、icons.map でコンポーネントを描画しているところの順番が変わったぐらいだったので大丈夫そう

  • export const All: Story = () => {
    return (
    <IconList>
    {icons.map((Component) => {
    return (
    <ItemWrapper key={`${Component.displayName}`}>
    <IconName>{Component.displayName?.replace(/Icon$/, '')}</IconName>
    <dd>
    <Component />
    </dd>
    </ItemWrapper>
    )
    })}
    </IconList>
    )
    }

Copy link
Contributor

@yt-ymmt yt-ymmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: !

@yamish123
Copy link
Contributor

@wmoai
これマージしちゃって大丈夫そうですか?

@wmoai
Copy link
Contributor Author

wmoai commented Jun 29, 2022

@yamish123 大丈夫です!

@yamish123 yamish123 merged commit 7670407 into master Jun 29, 2022
@yamish123 yamish123 deleted the builder-webpack5 branch June 29, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants