Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Compatible faraday v2 #44

Merged
merged 2 commits into from Nov 11, 2022
Merged

Compatible faraday v2 #44

merged 2 commits into from Nov 11, 2022

Conversation

mkmn
Copy link
Contributor

@mkmn mkmn commented Nov 10, 2022

Description

kiji depends on Faraday and does not specify a dependent version.
However, Faraday v2 has a change in the way Authorization header is specified.

The current code does not work with Faraday v2, so we will modify it.

Detail

  • Compatible Faraday v2
    • Stopped using BasicAuthentication
  • Updatre Dependency version
    • faraday required < v3
  • Add CI metrix config
    • Run test on the major version of each faraday.

ref.

lostisland/faraday#1306
https://lostisland.github.io/faraday/middleware/authentication

@mkmn mkmn marked this pull request as ready for review November 10, 2022 23:51
@mkmn mkmn requested a review from a team as a code owner November 10, 2022 23:51
@mkmn mkmn requested review from AtsushiM and alpaca-tc and removed request for a team November 10, 2022 23:51
@sato-s sato-s self-requested a review November 11, 2022 02:08
Copy link
Member

@sato-s sato-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkmn
Copy link
Contributor Author

mkmn commented Nov 11, 2022

thx.

@mkmn mkmn merged commit 2fb32d2 into kufu:master Nov 11, 2022
@mkmn mkmn deleted the compatible_faraday_v2 branch November 11, 2022 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants