Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haml を 6 系にバージョンアップ #79

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Haml を 6 系にバージョンアップ #79

merged 2 commits into from
Oct 5, 2022

Conversation

f440
Copy link
Member

@f440 f440 commented Sep 29, 2022

@f440 f440 requested a review from a team as a code owner September 29, 2022 03:58
@f440 f440 requested review from alpaca-tc and kouryou and removed request for a team September 29, 2022 03:58
@tknzk tknzk self-requested a review September 29, 2022 04:05
tknzk
tknzk approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@tknzk tknzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@f440 f440 mentioned this pull request Sep 30, 2022
Closed
@f440 f440 mentioned this pull request Oct 4, 2022
Closed
gongo
gongo approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@gongo gongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

views/layout.haml の修正前だとレイアウト崩れていた & 修正後問題なかったのが確認できました。 LGTM

@f440 f440 merged commit db54ab0 into kufu:master Oct 5, 2022
@f440 f440 deleted the haml-6 branch October 5, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongo gongo gongo approved these changes

@tknzk tknzk tknzk approved these changes

@alpaca-tc alpaca-tc Awaiting requested review from alpaca-tc alpaca-tc is a code owner automatically assigned from kufu/group-dev-oss

@kouryou kouryou Awaiting requested review from kouryou kouryou is a code owner automatically assigned from kufu/group-dev-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f440 @gongo @tknzk