chore: bump controller-runtime #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanz
force-pushed
the
controller-runtime-update
branch
3 times, most recently
from
5896c1a
to
8d5cede
Compare
jvanz
force-pushed
the
controller-runtime-update
branch
from
8d5cede
to
caaf8e1
Compare
|
This PR passed all the e2e tests. NOTE: This PR should be merged after this one in order to allow run the controller on development environment. |
viccuad
reviewed
Sep 26, 2023
| @@ -172,7 +171,7 @@ func (r *PolicyServerReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| }, | |||
| } | |||
| })). | |||
| Watches(&source.Kind{Type: &policiesv1.ClusterAdmissionPolicy{}}, handler.EnqueueRequestsFromMapFunc(func(object client.Object) []reconcile.Request { | |||
| Watches(&policiesv1.ClusterAdmissionPolicy{}, handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, object client.Object) []reconcile.Request { | |||
There was a problem hiding this comment.
I have been trying to understand from where these contexts come now, as they now seem to come from the Controller. Particularly, I am wondering on what happens if they timeout, as we could stop processing request through the webhook correctly and lock the cluster.
I have only come by this: kubernetes-sigs/controller-runtime#1334.
There was a problem hiding this comment.
Just in case, on the daily we agreed that this question should not block the merge.
viccuad
approved these changes
Sep 26, 2023
Bumps the controller-runtime dependency in use to v0.16.2. This required change in how we configure the controllers manager. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
jvanz
force-pushed
the
controller-runtime-update
branch
from
caaf8e1
to
04b6009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps the controller-runtime dependency in use to v0.16.2. This required change in how we configure the controllers manager.
Related to kubewarden/audit-scanner#39
Test
make testAdditional Information
This PR need to be updated and merged after merging the PR updating the
kube-webhook-wrapper.