-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use precompiled protoc #5959
Use precompiled protoc #5959
Conversation
Pull in protoc the right way, so that we can use a released binary instead of compiling protoc ourselves on every branch switch. Signed-off-by: Roman Mohr <rmohr@redhat.com>
/cc @kwiesmueller FYI |
@rmohr: GitHub didn't allow me to request PR reviews from the following users: FYI. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @dhiller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Pull in protoc the right way, so that we can use a released binary
instead of compiling protoc ourselves on every branch switch.
This saves quite some compile time during local development.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
For more context see bazelbuild/rules_scala#1142 and bazelbuild/rules_proto#36
Release note: