auto-bumper: Skip kube-secondary-dns #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
RamLavi
reviewed
Dec 7, 2022
|
considering this fails, i will check your approach |
Until go-git/go-git#485 is fixed since it blocks the auto bumper when cloning the KSD repository. https://github.com/kubevirt/cluster-network-addons-operator/actions/runs/3629947036/jobs/6122730934 Signed-off-by: Or Shoval <oshoval@redhat.com>
oshoval
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
Addressed comments, changed to skip the component instead of trying it |
oshoval
requested review from
RamLavi
and removed request for
qinqon and
rhrazdil
oshoval
added a commit
to oshoval/cluster-network-addons-operator
that referenced
this pull request
Dec 7, 2022
Bump KubeSecondaryDNS manually, since auto-bumper has problems. See kubevirt#1474 Signed-off-by: Or Shoval <oshoval@redhat.com>
RamLavi
reviewed
Dec 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Thanks |
oshoval
added a commit
to oshoval/cluster-network-addons-operator
that referenced
this pull request
Dec 7, 2022
Bump KubeSecondaryDNS manually, since auto-bumper has problems. See kubevirt#1474 Signed-off-by: Or Shoval <oshoval@redhat.com>
|
Is there a presubmit lane that checks auto-bumper compiles ? |
oshoval
added a commit
to oshoval/cluster-network-addons-operator
that referenced
this pull request
Dec 8, 2022
Bump KubeSecondaryDNS manually, since auto-bumper has problems. See kubevirt#1474 Signed-off-by: Or Shoval <oshoval@redhat.com>
oshoval
added a commit
to oshoval/cluster-network-addons-operator
that referenced
this pull request
Dec 8, 2022
Bump KubeSecondaryDNS manually, since auto-bumper has problems. See kubevirt#1474 Signed-off-by: Or Shoval <oshoval@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
* ksd: Deploy kubevirt Needed for the e2e tests Signed-off-by: Or Shoval <oshoval@redhat.com> * ksd: Bump manually to v0.0.7 Bump KubeSecondaryDNS manually, since auto-bumper has problems. See #1474 Signed-off-by: Or Shoval <oshoval@redhat.com> * ksd: Fix bump script Since the fields might have empty string, need to use set instead of update. Signed-off-by: Or Shoval <oshoval@redhat.com> * ksd: Run bump script (v0.0.7) Signed-off-by: Or Shoval <oshoval@redhat.com> Signed-off-by: Or Shoval <oshoval@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Skip KubeSecondaryDNS from auto-bumper.
Until go-git/go-git#485 is merged since
it blocks the auto bumper when cloning the KSD repository.
https://github.com/kubevirt/cluster-network-addons-operator/actions/runs/3629947036/jobs/6122730934
See go-git/go-git#495
Special notes for your reviewer:
Release note: