Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41604: fix cdrom bootOrder #1950

Merged
merged 1 commit into from
May 19, 2024

Conversation

upalatucci
Copy link
Member

馃摑 Description

If the cdrom is edited, it's already in the disks array so in that case its bootOder gets modified.
Check the disk name to determine which bootOrder to give.

馃帴 Demo

Screenshot from 2024-05-17 14-28-53

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 17, 2024

@upalatucci: This pull request references CNV-41604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

馃摑 Description

If the cdrom is edited, it's already in the disks array so in that case its bootOder gets modified.
Check the disk name to determine which bootOrder to give.

馃帴 Demo

Screenshot from 2024-05-17 14-28-53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and tnisan May 17, 2024 12:32
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 17, 2024
@upalatucci
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 19, 2024
Copy link
Contributor

openshift-ci bot commented May 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a1c74aa into kubevirt-ui:main May 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants