-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-41633: Fix VM list EmptyState on filtering with pod proxy #1945
CNV-41633: Fix VM list EmptyState on filtering with pod proxy #1945
Conversation
@upalatucci: This pull request references CNV-41633 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good 馃憤 just a small comment, and also maybe we want to locate this hook in a general location so other pages use this hook too?
3865912
to
e9bea32
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
馃摑 Description
When cluster has proxy pod enabled, the
unfilteredData
is empty as the proxy pod return empty array from the fetch even if the user just filtered data.In that case, just watch the selected filters. If we are using the pod for fetching data and the user has selected a filter, don't show the empty state.
Show the empty state if :
unfiltered data is empty if the cluster is not using the pod
if we are using the pod and unfiltered data is empty, check if the user has selected some filters from the query params (no other way to do it )