Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41633: Fix VM list EmptyState on filtering with pod proxy #1945

Conversation

upalatucci
Copy link
Member

馃摑 Description

When cluster has proxy pod enabled, the unfilteredData is empty as the proxy pod return empty array from the fetch even if the user just filtered data.

In that case, just watch the selected filters. If we are using the pod for fetching data and the user has selected a filter, don't show the empty state.

Show the empty state if :

unfiltered data is empty if the cluster is not using the pod
if we are using the pod and unfiltered data is empty, check if the user has selected some filters from the query params (no other way to do it )

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 15, 2024

@upalatucci: This pull request references CNV-41633 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

馃摑 Description

When cluster has proxy pod enabled, the unfilteredData is empty as the proxy pod return empty array from the fetch even if the user just filtered data.

In that case, just watch the selected filters. If we are using the pod for fetching data and the user has selected a filter, don't show the empty state.

Show the empty state if :

unfiltered data is empty if the cluster is not using the pod
if we are using the pod and unfiltered data is empty, check if the user has selected some filters from the query params (no other way to do it )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 15, 2024
Copy link
Member

@avivtur avivtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good 馃憤 just a small comment, and also maybe we want to locate this hook in a general location so other pages use this hook too?

src/views/virtualmachines/list/hooks/useSelectedFilters.ts Outdated Show resolved Hide resolved
@upalatucci upalatucci force-pushed the emptystate-on-filter-with-proxy branch from 3865912 to e9bea32 Compare May 23, 2024 13:04
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 3, 2024
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2691a21 into kubevirt-ui:main Jun 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants